Skip to content

feat: allow block publish if was published before Library v2 migration#38865

Open
asadali145 wants to merge 1 commit into
openedx:masterfrom
mitodl:asad/v1-v2-lib-migration-fixes-and-command
Open

feat: allow block publish if was published before Library v2 migration#38865
asadali145 wants to merge 1 commit into
openedx:masterfrom
mitodl:asad/v1-v2-lib-migration-fixes-and-command

Conversation

@asadali145

@asadali145 asadali145 commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the ability to publish a library content block if it was published before the V2 migration. This would be helpful for anyone having too many courses and libraries.

Testing instructions

  • Checkout mater branch
  • Create a legacy library and use it in a course.
  • Go to the content -> library update -> Review content updates and update the library references.
  • Go to the Unit with library content and notice that it is in draft.
  • Now checkout this branch and update the falg defaults to True and repeat the above steps. It should publish the block.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 9, 2026
@openedx-webhooks

openedx-webhooks commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Thanks for the pull request, @asadali145!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 9, 2026
@asadali145 asadali145 force-pushed the asad/v1-v2-lib-migration-fixes-and-command branch from 4db4e90 to 4f8a913 Compare July 9, 2026 10:30
@asadali145 asadali145 marked this pull request as ready for review July 9, 2026 11:12
arslanashraf7
arslanashraf7 suggested changes Jul 9, 2026
View reviewed changes
Comment thread cms/djangoapps/contentstore/tasks.py Outdated
Comment thread xmodule/library_content_block.py Outdated
Comment thread xmodule/tests/test_library_content.py Outdated
@asadali145 asadali145 force-pushed the asad/v1-v2-lib-migration-fixes-and-command branch from 4f8a913 to b59b9e4 Compare July 9, 2026 15:25
@asadali145 asadali145 requested a review from arslanashraf7 July 9, 2026 15:26
@asadali145 asadali145 force-pushed the asad/v1-v2-lib-migration-fixes-and-command branch from b59b9e4 to 1962ae8 Compare July 9, 2026 15:26
@asadali145

asadali145 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@arslanashraf7 this should be good for another look.

@asadali145 asadali145 mentioned this pull request Jul 9, 2026
Open
arslanashraf7
arslanashraf7 approved these changes Jul 10, 2026
View reviewed changes

@arslanashraf7 arslanashraf7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhan farhan Awaiting requested review from farhan farhan is a code owner
@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner
@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner
1 more reviewer
@arslanashraf7 arslanashraf7 arslanashraf7 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asadali145 @openedx-webhooks @arslanashraf7